Gilad Chaplik has posted comments on this change.
Change subject: core: Fix quota not inherited from VM to Template
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 359: &&
getParameters().getDiskInfoDestinationMap().get(diskImage.getId()) != null) {
Line 360:
createParams.setQuotaId(getParameters().getDiskInfoDestinationMap().get(diskImage.getId()).getQuotaId()
!= null
Line 361: ?
getParameters().getDiskInfoDestinationMap().get(diskImage.getId()).getQuotaId()
: null);
Line 362: } else {
Line 363: createParams.setQuotaId(diskImage.getQuotaId());
getQuotaStorageConsumptionParameters() uses this line for disk's quota (line
493):
Collection<DiskImage> disksList =
diskInfoDestinationMap.values().size() > 0 ?
diskInfoDestinationMap.values() :
getVm().getDiskList();
which is not the case here:
for (DiskImage diskImage : mImages) { // mImages = getVm().getDiskList()
..
your fix;
..
}
please use the same code for validating and setting.
Line 364: }
Line 365: // The return value of this action is the 'copyImage'
task GUID:
Line 366: VdcReturnValueBase retValue =
Backend.getInstance().runInternalAction(
Line 367: VdcActionType.CreateImageTemplate,
--
To view, visit http://gerrit.ovirt.org/12618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I697082483c706178b8ea47306779dc2b63da5ed6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
