Gilad Chaplik has posted comments on this change.
Change subject: core: Fix quota not inherited from VM to Template
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 487: // If the DiskInfoDestinationMap is available and contains
information about the disk
Line 488: if (getParameters().getDiskInfoDestinationMap() != null
Line 489: &&
getParameters().getDiskInfoDestinationMap().get(diskImage.getId()) != null) {
Line 490: return
getParameters().getDiskInfoDestinationMap().get(diskImage.getId()).getQuotaId();
Line 491: } else {
consider removing else clause
Line 492: return diskImage.getQuotaId();
Line 493: }
Line 494: }
Line 495:
--
To view, visit http://gerrit.ovirt.org/12618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I697082483c706178b8ea47306779dc2b63da5ed6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
