Liron Ar has posted comments on this change. Change subject: engine: connectStorageServer is not sent for inactive domains before connectStoragePool ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/dbscripts/storages_san_sp.sql Line 537: LANGUAGE plpgsql; Line 538: Line 539: Line 540: Line 541: Create or replace FUNCTION Getstorage_server_connectionsActiveUnknownInactiveByPoolId(v_storage_pool_id UUID) i referred to connections. Line 542: RETURNS SETOF storage_server_connections Line 543: AS $procedure$ Line 544: BEGIN Line 545: RETURN QUERY SELECT distinct storage_server_connections.* .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java Line 37: */ Line 38: List<StorageServerConnections> getAll(); Line 39: Line 40: /** Line 41: * Retrieves all Active, Unknown , InActive connections for the specified storage pool. I meant to change it regardless to InActive/Inactive - to clarify that the connections are of domain in the given statuses and that the status is not of the connection. Line 42: * Line 43: * @param pool Line 44: * the storage pool Line 45: * @return the list of connections -- To view, visit http://gerrit.ovirt.org/12805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb3710bb83ef81485715577ae939014ffcae693f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
