Yair Zaslavsky has posted comments on this change.

Change subject: engine: connectStorageServer is not sent for inactive domains 
before connectStoragePool
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java
Line 37:      */
Line 38:     List<StorageServerConnections> getAll();
Line 39: 
Line 40:     /**
Line 41:      * Retrieves all connections of Active/Unknown/InActive domains in 
the specified storage pool.
Comment should change - Retireves all connections that can be connected.
Line 42:      *
Line 43:      * @param pool
Line 44:      *            the storage pool
Line 45:      * @return the list of connections


--
To view, visit http://gerrit.ovirt.org/12805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3710bb83ef81485715577ae939014ffcae693f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to