Roy Golan has posted comments on this change.
Change subject: core: introduce osinfo service implementation over RMI
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/osinfo/server/LibosinfoJNAServiceImpl.java
Line 90: if (resources == null || cpuArch == null) {
Line 91: return null;
Line 92: }
Line 93:
Line 94: for (int i = 0; i <
lib.osinfo_list_get_length(resources.parent_instance); i++) {
I tried to avoid using generated classes by passing Structure around but I'm
having problems with this "parent_instance" nested structure. I have
represented it by a Pointer and I get a SEGFAULT when I'm passing it to
osinfo_list_get_length
if I get over this I throw most of the generated code
Line 95: OsinfoEntity entity =
lib.osinfo_list_get_nth(resources.parent_instance, i);
Line 96: String architecure = getResourceArchitecture(entity);
Line 97:
Line 98: if (cpuArch.equalsIgnoreCase(architecure)) {
--
To view, visit http://gerrit.ovirt.org/12937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia893bdc3dfc486e0b3e735f4e187996710a05f54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
