Roy Golan has posted comments on this change.
Change subject: core: introduce osinfo service implementation over RMI
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/osinfo/server/LibosinfoJNAServiceImpl.java
Line 91: return null;
Line 92: }
Line 93:
Line 94: for (int i = 0; i <
lib.osinfo_list_get_length(resources.parent_instance); i++) {
Line 95: OsinfoEntity entity =
lib.osinfo_list_get_nth(resources.parent_instance, i);
update: I've changed
OsinfoResourcesList get_XXX_resources(Pointer p)
to
OsinfoResourcesList.ByValue get_XXX_resources(Pointer p)
and it worked.
I can clean-up the rest of the generated code now
Line 96: String architecure = getResourceArchitecture(entity);
Line 97:
Line 98: if (cpuArch.equalsIgnoreCase(architecure)) {
Line 99: return new OsinfoResources(entity, null);
--
To view, visit http://gerrit.ovirt.org/12937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia893bdc3dfc486e0b3e735f4e187996710a05f54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
