Sahina Bose has posted comments on this change.
Change subject: gluster: Use brick server for advanced details
......................................................................
Patch Set 1: (3 inline comments)
Some suggestions inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 35: super(params);
Line 36: }
Line 37:
Line 38: @Override
Line 39: protected void executeQueryCommand() {
Can these private variables be initialized in the constructor from params.
otherwise there's a chance that they may not be set when using?
Line 40: clusterId = getParameters().getClusterId();
Line 41: detailRequired = getParameters().isDetailRequired();
Line 42: volumeId = getParameters().getVolumeId();
Line 43: if (volumeId != null) {
Line 121:
Line 122: // brick server is down
Line 123: return super.getUpServerId(clusterId);
Line 124: }
Line 125:
volumeName could be read inside the method from volumeId instead of passing as
a parameter.
Line 126: private GlusterVolumeAdvancedDetails fetchAdvancedDetails(String
volumeName) {
Line 127: VDSReturnValue returnValue =
Line 128:
runVdsCommand(VDSCommandType.GetGlusterVolumeAdvancedDetails,
Line 129: new
GlusterVolumeAdvancedDetailsVDSParameters(getUpServerId(),
Line 127: VDSReturnValue returnValue =
Line 128:
runVdsCommand(VDSCommandType.GetGlusterVolumeAdvancedDetails,
Line 129: new
GlusterVolumeAdvancedDetailsVDSParameters(getUpServerId(),
Line 130: clusterId,
Line 131: volumeName,
NPE possible here - as brick could be null. I think if brick is null, null
should be passed to the method, so that advanceddetails of all bricks are
fetched?
Line 132: brick.getQualifiedName(),
Line 133: detailRequired));
Line 134: return (GlusterVolumeAdvancedDetails)
returnValue.getReturnValue();
Line 135: }
--
To view, visit http://gerrit.ovirt.org/12979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
