Gilad Chaplik has posted comments on this change. Change subject: gluster: Use brick server for advanced details ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java Line 184: GlusterVolumeAdvancedDetails volumeAdvancedDetails = Line 185: (GlusterVolumeAdvancedDetails) getQuery().getQueryReturnValue().getReturnValue(); Line 186: Line 187: assertNotNull(volumeAdvancedDetails); Line 188: assertEquals(expectedVolumeAdvancedDetails, volumeAdvancedDetails); Do we need a test for brickId == null (returns any up host in cluster)? test either the entire command or getUpServerId(). Line 189: } -- To view, visit http://gerrit.ovirt.org/12979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
