Alon Bar-Lev has posted comments on this change. Change subject: packaging: engine-encrypt-passwd.sh as standalone script ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/tools/src/main/shell/engine-encrypt-passwd.sh Line 1 Line 2 Line 3 Line 4 during installation (new implementation), there are no parameter persisted into the filesystem, if there was previous installation there are the old parameter, we do not want to override anything unless we succeed installation, and they are not actually required to break this behavior. .................................................... File packaging/fedora/setup/basedefs.py Line 48: DIR_VAR_LOG="/var/log" Line 49: DIR_VAR_LIB="/var/lib" Line 50: DIR_LOG="%s/ovirt-engine/" % DIR_VAR_LOG Line 51: DIR_CONFIG="%s/ovirt-engine/conf" % DIR_USR_SHARE Line 52: DIR_JBOSS="/usr/share/jboss-as" This old setup code is using hard coded jboss dir in configuration as well, without ability to override it during installation. The new setup code will allow you to override any file location. It is here, only so the same script of engine password will be used, so we can live side by side. Line 53: DIR_JBOSS_RESOURCES="%s/ovirt-engine/resources/jboss" % DIR_USR_SHARE Line 54: DIR_KERBEROS="%s/ovirt-engine/kerberos" % DIR_USR_SHARE Line 55: DIR_ENGINE="/usr/share/%s" % (ENGINE_SERVICE_NAME) Line 56: DIR_PLUGINS="%s/ovirt-engine/scripts/plugins" % DIR_USR_SHARE -- To view, visit http://gerrit.ovirt.org/13031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b748fc787d44b2e877412f3107719d607b7a4ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
