Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-encrypt-passwd.sh as standalone script
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
I still think that if the optional installation program has special needs those
should be solved within the installation program instead of polluting the rest
of the code.
....................................................
File backend/manager/tools/src/main/shell/engine-encrypt-passwd.sh
Line 5: export JAVA_MODULEPATH="${JBOSS_HOME}/modules"
Line 6:
Line 7: # Load the prolog, not during installation
Line 8: [ -z "${ENGINE_CONFIG_IGNORE}" ] && \
Line 9: . "$(dirname "$(readlink -f "$0")")"/engine-prolog.sh
Use spaces for indentation, no tabs.
Line 10:
Line 11: die () {
Line 12: printf >&2 "$@"
Line 13: exit 1
--
To view, visit http://gerrit.ovirt.org/13031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b748fc787d44b2e877412f3107719d607b7a4ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
