Michael Kublin has posted comments on this change.
Change subject: core: Use one line error log instead stack trace.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
Line 163: String errorMessage =
Line 164: String
Line 165:
.format("EntityAsyncTask::EndCommandAction [within thread]: EndAction for
action type %1$s threw an exception",
Line 166: entityInfo.getActionType());
Line 167:
I have better idea, add toString() for VdcBLLException.
change message to log.error(, ex.toString())
add log.debug(ex)
Line 168: if (ex instanceof VdcBLLException) {
Line 169: log.errorFormat("Failed to end command due to
VDSM error {0} with code {1}.",
Line 170: ((VdcBLLException) ex).getErrorCode(),
Line 171: ((VdcBLLException)
ex).getErrorCode().getValue());
--
To view, visit http://gerrit.ovirt.org/12977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1907d94af939bbe6da6a2149428a97c5f33fe826
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
