Allon Mureinik has posted comments on this change. Change subject: core: Use one line error log instead stack trace. ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (2 inline comments) Please fix the commit message when you rebase. .................................................... Commit Message Line 3: AuthorDate: 2013-03-12 16:35:23 +0200 Line 4: Commit: Maor Lipchuk <[email protected]> Line 5: CommitDate: 2013-03-14 14:08:54 +0200 Line 6: Line 7: core: Use one line error log instead stack trace. s/instead/instead of/ Line 8: Line 9: Instead logging all the stack trace when failing to end a command after Line 10: task finishes, we will use one line error message, Line 11: that will indicate the error code and the error name got from VDSM. Line 5: CommitDate: 2013-03-14 14:08:54 +0200 Line 6: Line 7: core: Use one line error log instead stack trace. Line 8: Line 9: Instead logging all the stack trace when failing to end a command after s/Instead/Instead of/ Line 10: task finishes, we will use one line error message, Line 11: that will indicate the error code and the error name got from VDSM. Line 12: Line 13: Change-Id: I1907d94af939bbe6da6a2149428a97c5f33fe826 -- To view, visit http://gerrit.ovirt.org/12977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1907d94af939bbe6da6a2149428a97c5f33fe826 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
