Vered Volansky has posted comments on this change.
Change subject: [wip] core: move image group command
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(10 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 75: USER_ADD_DISK=Add-Disk operation of '${DiskAlias}' was initiated by
${UserName}.
Line 76: USER_ADD_DISK_FINISHED_SUCCESS=The disk '${DiskAlias}' was
successfully added.
Line 77: USER_ADD_DISK_FINISHED_FAILURE=Operation Add-Disk failed to complete.
Line 78: USER_FAILED_ADD_DISK=Operation Add-Disk failed (User: ${UserName}).
Line 79: MOVE_IMAGE_GROUP_FAILED_TO_DELETE_SRC_IMAGE=Possible failure when
deleting ${DiskAlias} from the source Storage Domain ${StorageDomainName}
during the move operation. the Storage Domain may be manually cleaned-up from
possible leftovers.
s/when/while, s/. the/. The
Line 80: USER_REMOVE_DISK_FROM_VM=Disk was removed from VM ${VmName} by
${UserName}.
Line 81: USER_FAILED_REMOVE_DISK_FROM_VM=Failed to remove Disk from VM
${VmName} (User: ${UserName}).
Line 82: USER_UPDATE_VM_DISK=VM ${VmName} ${DiskAlias} disk was updated by
${UserName}.
Line 83: USER_FAILED_UPDATE_VM_DISK=Failed to update VM ${VmName} disk
${DiskAlias} (User: ${UserName}).
....................................................
Commit Message
Line 9: Added MoveImageGroupCommand - making MoveOrCopyImageGroup command to be
Line 10: used for copy only (CopyImageGroup).
Line 11:
Line 12: Reasons for that change:
Line 13: 1. When moving a image and attempting to delete with wipe - the
s/a/an
Line 14: operation will be faster rather then waiting to the wipe to complete.
Line 15: 2. Moving toward lowering the SPM involvement in the copy/move process.
Line 16: 3. The engine will be able to tell on what part of the "move" operation
Line 17: an error occured.
Line 10: used for copy only (CopyImageGroup).
Line 11:
Line 12: Reasons for that change:
Line 13: 1. When moving a image and attempting to delete with wipe - the
Line 14: operation will be faster rather then waiting to the wipe to complete.
/s/to/for (first one)
Line 15: 2. Moving toward lowering the SPM involvement in the copy/move process.
Line 16: 3. The engine will be able to tell on what part of the "move" operation
Line 17: an error occured.
Line 18: 4. Move operation on vdsm should be deprecated.
Line 11:
Line 12: Reasons for that change:
Line 13: 1. When moving a image and attempting to delete with wipe - the
Line 14: operation will be faster rather then waiting to the wipe to complete.
Line 15: 2. Moving toward lowering the SPM involvement in the copy/move process.
/s/toward/towards
Line 16: 3. The engine will be able to tell on what part of the "move" operation
Line 17: an error occured.
Line 18: 4. Move operation on vdsm should be deprecated.
Line 19:
Line 12: Reasons for that change:
Line 13: 1. When moving a image and attempting to delete with wipe - the
Line 14: operation will be faster rather then waiting to the wipe to complete.
Line 15: 2. Moving toward lowering the SPM involvement in the copy/move process.
Line 16: 3. The engine will be able to tell on what part of the "move" operation
s/on what/in which
Line 17: an error occured.
Line 18: 4. Move operation on vdsm should be deprecated.
Line 19:
Line 20: Known issues and reasoning:
Line 13: 1. When moving a image and attempting to delete with wipe - the
Line 14: operation will be faster rather then waiting to the wipe to complete.
Line 15: 2. Moving toward lowering the SPM involvement in the copy/move process.
Line 16: 3. The engine will be able to tell on what part of the "move" operation
Line 17: an error occured.
has coocured
Line 18: 4. Move operation on vdsm should be deprecated.
Line 19:
Line 20: Known issues and reasoning:
Line 21: * The whole operations can be slower for moving image groups without
wipe
Line 14: operation will be faster rather then waiting to the wipe to complete.
Line 15: 2. Moving toward lowering the SPM involvement in the copy/move process.
Line 16: 3. The engine will be able to tell on what part of the "move" operation
Line 17: an error occured.
Line 18: 4. Move operation on vdsm should be deprecated.
Maybe - working towards deprecating Move ...
Line 19:
Line 20: Known issues and reasoning:
Line 21: * The whole operations can be slower for moving image groups without
wipe
Line 22: as the delete part is quick (and now we will have two vdsm calls
rather then one) -
Line 17: an error occured.
Line 18: 4. Move operation on vdsm should be deprecated.
Line 19:
Line 20: Known issues and reasoning:
Line 21: * The whole operations can be slower for moving image groups without
wipe
s/operations/operation, s/can/might
Line 22: as the delete part is quick (and now we will have two vdsm calls
rather then one) -
Line 23: this issue is known and accepted as part of this RFE.
Line 24:
Line 25: * The code hasn't been optimized for moving few 'related' disks at once
Line 18: 4. Move operation on vdsm should be deprecated.
Line 19:
Line 20: Known issues and reasoning:
Line 21: * The whole operations can be slower for moving image groups without
wipe
Line 22: as the delete part is quick (and now we will have two vdsm calls
rather then one) -
Do you mean due to two vdsm calls overhead? If so sneak it in. Otherwise it's
not clear why it's slower.
Line 23: this issue is known and accepted as part of this RFE.
Line 24:
Line 25: * The code hasn't been optimized for moving few 'related' disks at once
Line 26: as MoveVm/MoveVmTemplate are deprecated.
Line 21: * The whole operations can be slower for moving image groups without
wipe
Line 22: as the delete part is quick (and now we will have two vdsm calls
rather then one) -
Line 23: this issue is known and accepted as part of this RFE.
Line 24:
Line 25: * The code hasn't been optimized for moving few 'related' disks at once
s/few/several. And is this going to be answered in the future in this
patch/other patch or never?
Line 26: as MoveVm/MoveVmTemplate are deprecated.
Line 27:
Line 28: Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706
Line 29: Bug-Url: https://bugzilla.redhat.com/753549
--
To view, visit http://gerrit.ovirt.org/13042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
