Allon Mureinik has posted comments on this change.

Change subject: [wip] core: move image group command
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 263:     protected VdcActionType getImagesActionType() {
Line 264:         if (getParameters().getOperation() == ImageOperation.Move) {
Line 265:             return VdcActionType.MoveImageGroup;
Line 266:         }
Line 267:         return VdcActionType.MoveOrCopyImageGroup;
This command should also be separated into two commands - could be done in a 
separate patch
Line 268:     }
Line 269: 
Line 270:     @Override
Line 271:     protected void executeCommand() {


--
To view, visit http://gerrit.ovirt.org/13042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to