Frank Kobzik has posted comments on this change.
Change subject: frontend: Use console popup dialog in webadmin
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
Line 23: import org.ovirt.engine.ui.uicompat.Event;
Line 24: import org.ovirt.engine.ui.uicompat.EventArgs;
Line 25: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
Line 26:
Line 27: public class UserPortalItemModel extends EntityModel implements
ConsoleAwareModel
i agree. vszocs suggested this as well. i've already tried to do something
about it, but it was quite a big change as i remember. so i kept it this way.
nevertheless i can take a look at it once more to check whether i could find
some way to do it..
Line 28: {
Line 29:
Line 30: @Override
Line 31: public ConsoleProtocol getSelectedProtocol() {
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
Line 90
Line 91
Line 92
Line 93
Line 94
the only thing that is done here is the setupSelectedProtocol, that sets the
attribute selectedProtocol. but i think this attribute is redundant, because we
can infer it from from other attribute of the model when needed (see the method
canShowConsole).
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
Line 229: resources.consoleImage(),
resources.consoleDisabledImage()) {
Line 230: @Override
Line 231: protected UICommand resolveCommand() {
Line 232:
Line 233: UICommand command = new UICommand("ConsoleConnect",
new BaseCommandTarget() { // $NON-NLS-1$
i know it should be there. however, we want to make use of the ConsoleUtils and
ConsoleManager. and i don't think there is a nice way to use them in
uicommonweb. it's not under the management of gin. if you have some suggestion,
please share it.
Line 234: @Override
Line 235: public void ExecuteCommand(UICommand uiCommand) {
Line 236: String errorMessage =
consoleManager.connectToConsole(getMainModel());
Line 237: if (errorMessage != null) {
--
To view, visit http://gerrit.ovirt.org/12877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00158bbd8bd488dc527821b5f088fe598c9c2713
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
