Tomas Jelinek has posted comments on this change.
Change subject: frontend: Use console popup dialog in webadmin
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVirtualMachinePresenter.java
Line 61: super(eventBus, view, proxy, placeManager, modelProvider);
Line 62: this.consoleManager = consoleManager;
Line 63: this.errorPopupManager = errorPopupManager;
Line 64:
Line 65: getModel().getConsoleConnectEvent().addListener(new
IEventListener() {
be careful - this will not work after logout-login cycle as the models are
re-created but the presenters are singletons, so this presenter would still
listen to the old model. You need to listen to UiCommonInitEvent and do it in
it. Look for example at SubTabVirtualMachineGeneralPresenter.
Line 66: @Override
Line 67: public void eventRaised(Event ev, Object sender, EventArgs
args) {
Line 68: String errorMessage =
MainTabVirtualMachinePresenter.this.consoleManager.connectToConsole(getModel());
Line 69: if (errorMessage != null) {
--
To view, visit http://gerrit.ovirt.org/12877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00158bbd8bd488dc527821b5f088fe598c9c2713
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
