Liron Ar has posted comments on this change.

Change subject: core: export vm/create template shouldn't include ILLEGAL disks
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 656:      *            - Indication whether to allow only disks that are 
not shareable
Line 657:      * @param allowOnlySnapableDisks
Line 658:      *            - Indication whether to allow only disks which are 
allowed to be snapshoted.
Line 659:      * @param allowIllegalDisks
Line 660:      *            - Indication whether to allow only image disks 
which are in ILLEGAL status.
will remove the "only"
Line 661:      * @return - List filtered of disk images.
Line 662:      */
Line 663:     public static List<DiskImage> filterImageDisks(Collection<? 
extends Disk> listOfDisks,
Line 664:             boolean allowOnlyNotShareableDisks,


--
To view, visit http://gerrit.ovirt.org/13203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e608c0c87c6e3a8d275fd74658b888cde6c8694
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to