Liron Ar has posted comments on this change. Change subject: core: export vm/create template shouldn't include ILLEGAL disks ......................................................................
Patch Set 1: @Maor >> Why not blocking the user at the CDA phase? I think it will be more correct >> to tell the user he has to remove the disk before creating a new template or >> export a VM, instead exporting the Template and automatically decide for him >> to do it without the disk. Re: Thought about that option but in terms of UI it might be better to not force him to remove the disk - i'm open for opinions..if we want to go that way, I have no problem to change it. >> Audit Log Re: I don't think that it's needed, we don't have proper place to it..it should be obvious that disks with illegal status do not "participate" in the operation- the same as we don't log when we filter out shareable disks and snappable disks. -- To view, visit http://gerrit.ovirt.org/13203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e608c0c87c6e3a8d275fd74658b888cde6c8694 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
