Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(2 inline comments)
Some very minor comments, the patch looks good.
I have a question, you wrote that "I changed the gwt.locale back to 'default'
in frontend/webadmin/modules/pom.xml"
but this pom.xml still contains "en", so the patch works regardless?
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml
Line 39:
Line 40: <!-- Supported locales (defined via maven property) -->
Line 41: <extend-property name="locale" values="en,es,fr,ja,pt_BR,zh_CN"
/>
Line 42: <set-property name="locale" value="${gwt.locale}" />
Line 43: <set-property-fallback name="locale" value="en" />
Please retain newline after this for better readability.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml
Line 39:
Line 40: <!-- Supported locales (defined via maven property) -->
Line 41: <extend-property name="locale" values="en,es,fr,ja,pt_BR,zh_CN"
/>
Line 42: <set-property name="locale" value="${gwt.locale}" />
Line 43: <set-property-fallback name="locale" value="en" />
Please retain newline after this for better readability.
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
