Vojtech Szocs has posted comments on this change.

Change subject: webadmin: Select english when browser is other locale
......................................................................


Patch Set 5:

> Your patch set changed this to: <gwt.locale>en</gwt.locale> My patch set 
> changed it back to the original <gwt.locale>default</gwt.locale>

Sorry, let me rephrase my question: frontend/webadmin/modules/pom.xml still 
contains <gwt.locale>en,...</gwt.locale> instead of 
<gwt.locale>default,...</gwt.locale> within "all-langs" profile.

So I was wondering, why did you use <gwt.locale>default</gwt.locale> as the 
default "gwt.locale" property value? Shouldn't this be set to "en", e.g. a 
value taken from "all-langs" profile?

--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to