Laszlo Hornyak has posted comments on this change.
Change subject: engine: hashcode method simplification (1/2) [wip]
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java
Line 21: public static boolean bigDecimalEqual(BigDecimal bd1, BigDecimal
bd2) {
Line 22: return bd1 == bd2 || bd1 != null && bd2 != null &&
bd1.compareTo(bd2) == 0;
Line 23: }
Line 24:
Line 25: public static int hashOrZero(Object obj) {
ok, agreed
Line 26: if(obj == null) {
Line 27: return 0;
Line 28: } else {
Line 29: return obj.hashCode();
--
To view, visit http://gerrit.ovirt.org/13385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad4e8f2e57728b97f0f72aa87c199b00fa242f6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
