Greg Padgett has posted comments on this change. Change subject: engine: hashcode method simplification [wip] ......................................................................
Patch Set 2: Looks good to me, but someone else must approve I like it. Allon, I looked into this and iirc commons-lang isn't supported by gwt. But glad you mentioned it because it deserves a mention, it's got some nice builders for toString and equals that we could consider emulating, too. -- To view, visit http://gerrit.ovirt.org/13385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ad4e8f2e57728b97f0f72aa87c199b00fa242f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
