Allon Mureinik has uploaded a new change for review. Change subject: core: Remove IsVdsGroupWithSameNameExist ......................................................................
core: Remove IsVdsGroupWithSameNameExist IsVdsGroupWithSameNameExistQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The IsVdsGroupWithSameNameExistQuery class 2. The IsVdsGroupWithSameNameExist constant representing it in VdcQueryType 3. The IsVdsGroupWithSameNameExistParameters class which was only used by the removed query class. Change-Id: I45467851d4f11b3f94496974cf6665c7206daeb5 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsGroupWithSameNameExistQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 36 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/13592/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsGroupWithSameNameExistQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsGroupWithSameNameExistQuery.java deleted file mode 100644 index 257b6f6..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsGroupWithSameNameExistQuery.java +++ /dev/null @@ -1,17 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.*; -import org.ovirt.engine.core.dal.dbbroker.*; - -public class IsVdsGroupWithSameNameExistQuery<P extends IsVdsGroupWithSameNameExistParameters> - extends QueriesCommandBase<P> { - public IsVdsGroupWithSameNameExistQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue( - DbFacade.getInstance().getVdsGroupDao().getByName(getParameters().getName()) != null); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java deleted file mode 100644 index 93b8478..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public class IsVdsGroupWithSameNameExistParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 6145884648491618837L; - - public IsVdsGroupWithSameNameExistParameters(String name) { - _name = name; - } - - private String _name; - - public String getName() { - return _name; - } - - public IsVdsGroupWithSameNameExistParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 12a2b48..ac91c36 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -63,7 +63,6 @@ GetVdsGroupByVdsGroupId(VdcQueryAuthType.User), // needed when updating VM GetVdsGroupById(VdcQueryAuthType.User), GetVdsGroupByName(VdcQueryAuthType.User), - IsVdsGroupWithSameNameExist, GetVdsGroupsByStoragePoolId(VdcQueryAuthType.User), // Certificate -- To view, visit http://gerrit.ovirt.org/13592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45467851d4f11b3f94496974cf6665c7206daeb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
