Allon Mureinik has uploaded a new change for review. Change subject: core: Remove GetUsersByVmid ......................................................................
core: Remove GetUsersByVmid GetUsersByVmidQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetUsersByVmidQuery class 2. The GetUsersByVmid constant representing it in VdcQueryType 3. The GetUsersByVmidParameters class which was only used by the removed query class. Change-Id: I00b2145e4a63d553427afb802d2a6fb2ef78157b Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUsersByVmidQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUsersByVmidParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 43 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/13593/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUsersByVmidQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUsersByVmidQuery.java deleted file mode 100644 index 87fa903..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUsersByVmidQuery.java +++ /dev/null @@ -1,22 +0,0 @@ -package org.ovirt.engine.core.bll; - -import java.util.List; - -import org.ovirt.engine.core.common.businessentities.DbUser; -import org.ovirt.engine.core.common.queries.GetUsersByVmidParameters; -import org.ovirt.engine.core.dal.dbbroker.DbFacade; - -public class GetUsersByVmidQuery<P extends GetUsersByVmidParameters> extends - QueriesCommandBase<P> { - public GetUsersByVmidQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - List<DbUser> users = DbFacade.getInstance().getDbUserDao() - .getAllForVm(getParameters().getVmId()); - - getQueryReturnValue().setReturnValue(users); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUsersByVmidParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUsersByVmidParameters.java deleted file mode 100644 index f0fd56c..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUsersByVmidParameters.java +++ /dev/null @@ -1,20 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class GetUsersByVmidParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 8439269144799226825L; - - public GetUsersByVmidParameters(Guid id) { - _id = id; - } - - private Guid _id = new Guid(); - - public Guid getVmId() { - return _id; - } - - public GetUsersByVmidParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index ac91c36..7ff7b11 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -95,7 +95,6 @@ GetUserVmsByUserIdAndGroups(VdcQueryAuthType.User), GetAllDbUsers(VdcQueryAuthType.User), GetDbUserByUserId(VdcQueryAuthType.User), - GetUsersByVmid, GetVmsByUserid, GetUserBySessionId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/13593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00b2145e4a63d553427afb802d2a6fb2ef78157b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
