Allon Mureinik has uploaded a new change for review. Change subject: core: Remove GetVmsByUserid ......................................................................
core: Remove GetVmsByUserid GetVmsByUseridQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetVmsByUseridQuery class 2. The GetVmsByUserid constant representing it in VdcQueryType 3. The GetVmsByUseridParameters class which was only used by the removed query class. Change-Id: I1ed4821fceb06fbce6ac3f4b3851d903637b3132 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByUseridQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByUseridParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 39 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/13594/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByUseridQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByUseridQuery.java deleted file mode 100644 index 8be8c34..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByUseridQuery.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.GetVmsByUseridParameters; -import org.ovirt.engine.core.dal.dbbroker.DbFacade; - -public class GetVmsByUseridQuery<P extends GetVmsByUseridParameters> extends - QueriesCommandBase<P> { - public GetVmsByUseridQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue( - DbFacade.getInstance().getVmDao() - .getAllForUser(getParameters().getUserId())); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByUseridParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByUseridParameters.java deleted file mode 100644 index 55e8ac9..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByUseridParameters.java +++ /dev/null @@ -1,20 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class GetVmsByUseridParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = -5292104747871231090L; - - public GetVmsByUseridParameters(Guid id) { - _id = id; - } - - private Guid _id = new Guid(); - - public Guid getUserId() { - return _id; - } - - public GetVmsByUseridParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 7ff7b11..ee9e152 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -95,7 +95,6 @@ GetUserVmsByUserIdAndGroups(VdcQueryAuthType.User), GetAllDbUsers(VdcQueryAuthType.User), GetDbUserByUserId(VdcQueryAuthType.User), - GetVmsByUserid, GetUserBySessionId(VdcQueryAuthType.User), // AdGroups queries -- To view, visit http://gerrit.ovirt.org/13594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ed4821fceb06fbce6ac3f4b3851d903637b3132 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
