Allon Mureinik has uploaded a new change for review. Change subject: core: Remove GetVmPoolMapByVmPoolId ......................................................................
core: Remove GetVmPoolMapByVmPoolId GetVmPoolMapByVmPoolIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetVmPoolMapByVmPoolIdQuery class 2. The GetVmPoolMapByVmPoolId constant representing it in VdcQueryType 3. The GetVmPoolMapByVmPoolIdParameters class which was only used by the removed query class. Change-Id: I26120323c99b3043321032d3c495dc7faed0a8b3 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolsMapByVmPoolIdQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 31 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/13595/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolsMapByVmPoolIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolsMapByVmPoolIdQuery.java deleted file mode 100644 index 6bbf6ad..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolsMapByVmPoolIdQuery.java +++ /dev/null @@ -1,16 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.GetVmPoolsMapByVmPoolIdParameters; -import org.ovirt.engine.core.dal.dbbroker.DbFacade; - -public class GetVmPoolsMapByVmPoolIdQuery<P extends GetVmPoolsMapByVmPoolIdParameters> extends QueriesCommandBase<P> { - public GetVmPoolsMapByVmPoolIdQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue(DbFacade.getInstance() - .getVmPoolDao().getVmPoolsMapByVmPoolId(getParameters().getPoolId())); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java deleted file mode 100644 index 160e590..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java +++ /dev/null @@ -1,14 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class GetVmPoolsMapByVmPoolIdParameters extends GetVmPoolByIdParametersBase { - private static final long serialVersionUID = -2006515844211778283L; - - public GetVmPoolsMapByVmPoolIdParameters(Guid poolId) { - super(poolId); - } - - public GetVmPoolsMapByVmPoolIdParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index ee9e152..43a76c6 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -103,7 +103,6 @@ // VM pools queries GetVmPoolById(VdcQueryAuthType.User), - GetVmPoolsMapByVmPoolId, GetAllVmPools, HasFreeVmsInPool, GetAllVmPoolsAttachedToUser(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/13595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I26120323c99b3043321032d3c495dc7faed0a8b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
