Douglas Schilling Landgraf has posted comments on this change. Change subject: restapi: ProductInfo use ProductRPMVersion ......................................................................
Patch Set 4: Hi Michael, > this would be an api break, please keep using old > VdcVersion > and for the RPMVersion add new element rpm_version Is it really necessary keep using VdcVersion? We provide the same data to users (major,minor,build,revision) without breaking the api with RPMVersion. However, this patch adds full_version (see below) is it the api break?. If yes, we might add engine_version element instead of rpm_version because it won't be valid for Ubuntu and others distros that are not based on the RPM schema. (I intend to provide another patch to change the ProductRPMVersion to a generic name). 'major': '3', 'full_version': '3.2.0-10.0.63.20130329gitd3892f0.douglas.master.el6ev', 'build': '0', 'minor': '2', 'revision': '0' Thanks! -- To view, visit http://gerrit.ovirt.org/13420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c03460ef1af943278ab6f5171c042afdf4d392 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
