Ravi Nori has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VersionHelper.java
Line 11: */
Line 12: public static Version parseVersion(String text) {
Line 13: Version version = new Version();
Line 14: String parts[] = text.split("\\.", -1);
Line 15:
Please bring back switch statement. This could throw array index out of bounds
exception
Line 16: version.setFullVersion(text);
Line 17: version.setMajor(Integer.parseInt(parts[0]));
Line 18: version.setMinor(Integer.parseInt(parts[1]));
Line 19:
--
To view, visit http://gerrit.ovirt.org/13420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c03460ef1af943278ab6f5171c042afdf4d392
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
