Deepak C Shetty has posted comments on this change.
Change subject: core: WIP: Add support for backup/restore API for ISVs
......................................................................
Patch Set 1: (2 inline comments)
my 2 cents :)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Backup.java
Line 33:
Line 34: /**
Line 35: * The snapshot captured by the backup.
Line 36: */
Line 37: private Snapshot snapshot;
IIUC This is the snapshot that was used as the src for the backup, so the
comment is misleading... it sounds as if snapshot was created from backup, i
think its the other way. If the above is correct, then do we need to store the
snapshot here, since it would most probably be a temp snapshot created just for
the purpose of backup, and would be deleted post backup is done
Line 38:
Line 39: public Backup(Guid id,
Line 40: BackupStatus status,
Line 41: String description,
Line 46: this.description = description;
Line 47: this.creationDate = creationDate;
Line 48: this.snapshot = snapshot;
Line 49: }
Line 50:
We probably need to track the following too...
1) The path/id/UUID of the VM and/or vmdisk whose backup is being represented
by this class
2) Do we need to associate this with a Restore class' instance, which will have
all the necessary data encapsulated inside it, for restoring the Backup ?
3) Whether it was a offline disk backup or online backup
4) Whether its a full back or differential or incremental type
Line 51: @Override
Line 52: public Guid getId() {
Line 53: return id;
Line 54: }
--
To view, visit http://gerrit.ovirt.org/13279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f48e96856acc47bc748aed777f11c6ebee3f140
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
