Alon Bar-Lev has posted comments on this change.
Change subject: packaging: refactored firewalld support
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/fedora/setup/http.xml
Line 1: <?xml version="1.0" encoding="utf-8"?>
Line 2: <service>
Line 3: <short>ovirt-http</short>
Line 4: <description>oVirt configured http service</description>
Line 5: <port protocol="tcp" port="80"/>
If this is a template, I expect it to be xml.in and @PORT@ as placeholder... it
will allow you to use the common_utils.processTemplate() without xml magic.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 582: # Firewalld configuration
Line 583: %dir %{engine_etc}/firewalld
Line 584: %config(noreplace) %{engine_etc}/firewalld/nfs.xml
Line 585: %config(noreplace) %{engine_etc}/firewalld/http.xml
Line 586: %config(noreplace) %{engine_etc}/firewalld/https.xml
Not sure I like this to be %config, if user wish to override he can create a
different service file after our, no?
Line 587:
Line 588: # Man pages
Line 589: %{_mandir}/man8/engine-setup.*
Line 590: %{_mandir}/man8/engine-upgrade.*
--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a60e1667182f926f399e22bbfbb939e7171cb0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
