Alon Bar-Lev has posted comments on this change.

Change subject: packaging: refactored firewalld support
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 582: # Firewalld configuration
Line 583: %dir %{engine_etc}/firewalld
Line 584: %config(noreplace) %{engine_etc}/firewalld/nfs.xml
Line 585: %config(noreplace) %{engine_etc}/firewalld/http.xml
Line 586: %config(noreplace) %{engine_etc}/firewalld/https.xml
ok... let's make rpmlint happy!

But thinking about this... why put this at etc?
Line 587: 
Line 588: # Man pages
Line 589: %{_mandir}/man8/engine-setup.*
Line 590: %{_mandir}/man8/engine-upgrade.*


--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6a60e1667182f926f399e22bbfbb939e7171cb0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to