Maor Lipchuk has posted comments on this change.
Change subject: wip: core: remove as sync verb.
......................................................................
Patch Set 3: (1 inline comment)
There will be a problem when ever engine will be restarted.
Scenario: 1)Remove VM with 3 disks.
2) First two disks will get ImageDoesNotExists.
3) Engine restarts
4) VM will stay in the setup with only one disk, and no indication there was a
problem.
I also think we might encounter this problem on revert scenarios as well
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 85: getParameters().getParentCommand(),
Line 86: VdcObjectType.Storage,
Line 87: getParameters().getStorageDomainId()));
Line 88: } catch (VdcBLLException e) {
Line 89: if (e.getErrorCode() !=
VdcBllErrors.ImageDoesNotExistInDomainError) {
IMO there must be a warning log if the image does not exists.
Line 90: throw e;
Line 91: }
Line 92: }
Line 93:
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
