Allon Mureinik has posted comments on this change.
Change subject: wip: core: remove as sync verb.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
See inline - there are some points I don't get about this patch.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 265: p.setParentParameters(getParameters());
Line 266: p.setRemoveFromSnapshots(true);
Line 267:
p.setStorageDomainId(getParameters().getStorageDomainId());
Line 268: p.setForceDelete(getParameters().getForceDelete());
Line 269: if (diskImage.getStorageIds().size() > 1) {
Shouldn't this be ">=" ?
I don't understand this change.
Line 270: p.setRemoveFromDB(false);
Line 271: }
Line 272: VdcReturnValueBase vdcReturnValue =
Line 273:
Backend.getInstance().runInternalAction(VdcActionType.RemoveImage,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java
Line 123: } else {
Line 124: getReturnValue().setFault(vdcRetValue.getFault());
Line 125: }
Line 126: }
Line 127: EndRemoveTemplate();
Just remove this method - it became useless.
Line 128: }
Line 129:
Line 130: @Override
Line 131: public AuditLogType getAuditLogTypeValue() {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java
Line 12:
Line 13: public RemoveImageParameters(Guid imageId) {
Line 14: super(imageId, null);
Line 15: setForceDelete(false);
Line 16: removeFromDB = true;
After this change, why do I still need this boolean?
Line 17: }
Line 18:
Line 19: public RemoveImageParameters() {
Line 20: }
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
