Liron Ar has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 57: if (newConnectionDetails.getstorage_type() == StorageType.NFS
&& !new
NfsMountPointConstraint().isValid(newConnectionDetails.getconnection(), null)) {
Line 58: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
Line 59: }
Line 60:
Line 61: if (newConnectionDetails.getstorage_type() ==
StorageType.POSIXFS && (newConnectionDetails.getVfsType() == null ||
newConnectionDetails.getVfsType().isEmpty())) {
perhaps use here apache commans StringUtils.isEmpty() instead.
Line 62: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE);
Line 63: }
Line 64:
Line 65: Guid vdsmId = getParameters().getVdsId();
--
To view, visit http://gerrit.ovirt.org/13640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8904ffab80e9d6e6bfdee4b8375872d1ff64b4d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
