ofri masad has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
Line 124: validateResult(runVmValidator.validateBootSequence(new VM(),
BootSequence.N, new ArrayList<Disk>()),
Line 125: false,
Line 126:
VdcBllMessages.VM_CANNOT_RUN_FROM_NETWORK_WITHOUT_NETWORK);
Line 127: }
Line 128:
What about:
- No disk - boot from network
- no iso domain - boot from network
- no iso domain - boot from disk
- no network - boot from disk
- no network - boot from iso domain
Line 129: private VmPropertiesUtils mockVmPropertiesUtils() {
Line 130: VmPropertiesUtils utils = spy(new VmPropertiesUtils());
Line 131: doReturn("sap_agent=^(true|false)$;sndbuf=^[0-9]+$;" +
Line 132:
"vhost=^(([a-zA-Z0-9_]*):(true|false))(,(([a-zA-Z0-9_]*):(true|false)))*$;" +
--
To view, visit http://gerrit.ovirt.org/13399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida913a72e04c4edc57f9b6e2baf93e31e3df82f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
