Michael Kublin has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 75: */
Line 76: private IsoDomainListSyncronizer() {
Line 77: init();
Line 78: }
Line 79:
make this method call from static constructor
Line 80: protected void init() {
Line 81: log.info("Start initializing " + getClass().getSimpleName());
Line 82: repoStorageDom =
DbFacade.getInstance().getRepoFileMetaDataDao();
Line 83: isoDomainRefreshRate = Config.<Integer>
GetValue(ConfigValues.AutoRepoDomainRefreshTime) * MIN_TO_MILLISECONDS;
Line 93:
Line 94: /**
Line 95: * Returns the singleton instance.
Line 96: * @return Singleton instance of IsoDomainManager
Line 97: */
this is not singleton now
Line 98: public static IsoDomainListSyncronizer getInstance() {
Line 99: if(isoDomainListSyncronizer == null) {
Line 100: isoDomainListSyncronizer = new IsoDomainListSyncronizer();
Line 101: }
--
To view, visit http://gerrit.ovirt.org/13398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icce0924f3b7875752b4ff1df7b55d9e293da5cd6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
