Yair Zaslavsky has uploaded a new change for review. Change subject: tools: Fixing mailserver validation ......................................................................
tools: Fixing mailserver validation This solves mail server validation - In case MAILSERVER does not exist, a proper error will be reported indicating MAILSERVER should exist and not be empty. In case MAILSERVER exists, but empty or with a non resolvable content, a proper error indicating the MAILSEFVER should contian resolvable address will be reported. Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Bug-Url: https://bugzilla.redhat.com/921405 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/13735/1 diff --git a/backend/manager/tools/src/main/shell/engine-notifier.sh b/backend/manager/tools/src/main/shell/engine-notifier.sh index 2617bfe..e8605c6 100755 --- a/backend/manager/tools/src/main/shell/engine-notifier.sh +++ b/backend/manager/tools/src/main/shell/engine-notifier.sh @@ -84,6 +84,12 @@ die "Error: \$MAIL_SERVER is not defined, please check for this in configuration file $CONF_FILE\n" 6 fi +nslookup $MAIL_SERVER &>/dev/null +if [ $? -ne 0 ] ; then + die "Error: MAIL_SERVER must contain resolvable address" +fi + + # Now check for properties that if defined, can not be empty # INTERVAL_IN_SECONDS if defined can not be empty if [ "${INTERVAL_IN_SECONDS+x}" ]; then -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
