Moti Asayag has posted comments on this change. Change subject: tools: Fixing mailserver validation ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/tools/src/main/shell/engine-notifier.sh Line 85: fi Line 86: Line 87: nslookup $MAIL_SERVER &>/dev/null Line 88: if [ $? -ne 0 ] ; then Line 89: die "Error: MAIL_SERVER must contain resolvable address" Please add \$MAIL_SERVER to comply with other messages convention and also print the value of it to ease the troubleshooting. e.g.: "Error: \$MAIL_SERVER ($MAIL_SERVER) must contain resolvable address" Line 90: fi Line 91: Line 92: Line 93: # Now check for properties that if defined, can not be empty .................................................... Commit Message Line 4: Commit: Yair Zaslavsky <[email protected]> Line 5: CommitDate: 2013-04-09 11:00:21 +0300 Line 6: Line 7: tools: Fixing mailserver validation Line 8: s/MAILSERVER/MAIL_SERVER/g Line 9: This solves mail server validation - Line 10: In case MAILSERVER does not exist, a proper Line 11: error will be reported indicating MAILSERVER should Line 12: exist and not be empty. -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
