Moti Asayag has posted comments on this change.
Change subject: engine: Support 3.1 network topologies by AttachNetwork
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
Line 205: }
Line 206:
Line 207: // Verify Non-VM networks are supported
Line 208: if
(!FeatureSupported.nonVmNetwork(getVds().getVdsGroupCompatibilityVersion())
Line 209: && (!iface.isBridged() ||
!attachedNetwork.isVmNetwork() || !logicalNetwork.isVmNetwork())) {
this condition will prevent attach vlans for example to a host with a non-vm
network on its nic (e.g. a host which was moved from 3.1 cluster to 3.0
cluster).
We may agree that checking the networks in this context might be redundant
since there is no code path which might result with a non-vm network on 3.0
cluster. Therefore i'll remove this on the next patch.
Line 210: return false;
Line 211: }
Line 212:
Line 213: // Prevent attaching non-VM network to a nic which already
has an attached non-VM network
--
To view, visit http://gerrit.ovirt.org/13722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e1abe84e2877171be5af41c9bb3ab590fed3653
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
