Mike Kolesnik has posted comments on this change.
Change subject: engine: Support 3.1 network topologies by AttachNetwork
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
Line 121: }
Line 122:
Line 123: Map<String, Network> networksByName =
Line 124:
Entities.entitiesByName(getNetworkDAO().getAllForCluster(getVds().getVdsGroupId()));
Line 125: // check that the network exists in current cluster
Please add empty line before comments
Line 126: if
(!networksByName.containsKey(params.getNetwork().getName())) {
Line 127:
addCanDoActionMessage(VdcBllMessages.NETWORK_NOT_EXISTS_IN_CLUSTER);
Line 128: return false;
Line 129: } else {
Line 193: return true;
Line 194: }
Line 195:
Line 196: Network attachedNetwork =
networksByName.get(iface.getNetworkName());
Line 197: // Prevent attaching a network if unmanaged network is
already attached to the nic
Please add empty line before comments
Line 198: if (attachedNetwork == null) {
Line 199: return false;
Line 200: }
Line 201:
Line 203: if (vmNetworkNonVlan(attachedNetwork) ||
vmNetworkNonVlan(logicalNetwork)) {
Line 204: return false;
Line 205: }
Line 206:
Line 207: // Verify non-VM networks exists on a host within
incompatible cluster's version
This comment is confusing, perhaps you meant "Verify that non-VM network can
exist on the host only if the feature is supported for the cluster".
Line 208: if
(!FeatureSupported.nonVmNetwork(getVds().getVdsGroupCompatibilityVersion()) &&
(!iface.isBridged())) {
Line 209: return false;
Line 210: }
Line 211:
--
To view, visit http://gerrit.ovirt.org/13722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e1abe84e2877171be5af41c9bb3ab590fed3653
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
