Juan Hernandez has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ipa/OpenLdapUserContextMapper.java
Line 25:
Line 26: try {
Line 27: return attributes.get("uid").get(0);
Line 28: } catch (NamingException e) {
Line 29: System.err.println(ERROR_PREFIX + "Failed getting user
GUID");
Please replace this ^ with "log.error(...)".
Line 30: return null;
Line 31: }
Line 32: }
Line 33:
--
To view, visit http://gerrit.ovirt.org/13829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa5c92088a34d8c3881ce839963a13fe9ca4f84
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Uwe Grawert <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
