Roy Golan has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapLdapGuidEncoder.java
Line 7: @Override
Line 8: public String encodeGuid(Guid guid) {
Line 9: return guid.toString();
Line 10: }
Line 11:
our fault that we didn't supply a DefaultGuidEncoder with that impl. Except AD
all servers encode it the same.
Can you rename this class to DefaultGuidEncoder? I'll help with a subsequent
patch that deletes the other duplicates and uses it.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapRootDSEContextMapper.java
Line 10: import org.ovirt.engine.core.utils.log.LogFactory;
Line 11: import org.springframework.ldap.core.ContextMapper;
Line 12: import org.springframework.ldap.core.DirContextAdapter;
Line 13:
Line 14: public class OpenLdapRootDSEContextMapper implements ContextMapper {
same as former?
Line 15:
Line 16: private static Log log =
LogFactory.getLog(OpenLdapRootDSEContextMapper.class);
Line 17:
Line 18: public final static String[] ROOTDSE_ATTRIBUTE_FILTER = {
namingContexts.name() };
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapRootDSE.java
Line 3: import javax.naming.NamingException;
Line 4: import javax.naming.directory.Attribute;
Line 5: import javax.naming.directory.Attributes;
Line 6:
Line 7:
same as IPA, RHDS and ITDS RootDSE - see my comments and the former class
Line 8: public class OpenLdapRootDSE implements RootDSE {
Line 9:
Line 10: private String defaultNamingContext;
Line 11:
--
To view, visit http://gerrit.ovirt.org/13829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa5c92088a34d8c3881ce839963a13fe9ca4f84
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Uwe Grawert <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Uwe Grawert <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
