Allon Mureinik has posted comments on this change.
Change subject: engine: AssingQuota button under disks refresh bug
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
The database changes seems reasonable.
@Daniel - please review the frontend change.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java
Line 78: * and all the selected disks quota mode !=
QuotaEnforcementTypeEnum.DISABLED.
Line 79: * @param changeQuotaCommad
Line 80: */
Line 81: public static void
updateChangeQuotaActionAvailability(IChangeQuotaCommadAvailability
changeQuotaCommad) {
Line 82: boolean isAvailable = true, isExecutionAllowed = true;
break this up to two statements.
there are very few places where the quota operator makes sense, this is not one
of them.
Line 83: if (changeQuotaCommad.getSystemTreeSelectedItem() != null
Line 84: &&
changeQuotaCommad.getSystemTreeSelectedItem().getType() ==
SystemTreeItemType.DataCenter) {
Line 85: List<Disk> selectedDisks =
changeQuotaCommad.getSelectedDisks();
Line 86: if (selectedDisks != null && !selectedDisks.isEmpty()) {
--
To view, visit http://gerrit.ovirt.org/13925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
