Daniel Erez has posted comments on this change. Change subject: engine: AssingQuota button under disks refresh bug ......................................................................
Patch Set 4: (4 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-04-15 12:29:00 +0300 Line 4: Commit: Gilad Chaplik <[email protected]> Line 5: CommitDate: 2013-04-15 16:13:27 +0300 Line 6: Line 7: engine: AssingQuota button under disks refresh bug s/AssingQutoa/AssignQuota Line 8: Line 9: In case a quota mode set to !Disabled (or vice-versa) the Line 10: Assing Quota button (in various disk tabs) availability wasn't refreshed. Line 11: Line 6: Line 7: engine: AssingQuota button under disks refresh bug Line 8: Line 9: In case a quota mode set to !Disabled (or vice-versa) the Line 10: Assing Quota button (in various disk tabs) availability wasn't refreshed. s/Assing/Assign Line 11: Line 12: The problem caused because we relied on the selected DC tree Line 13: item quota mode, which not getting refreshed in current ui infrastructure. Line 14: Instead we will fetch quota mode from disk BE itself. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java Line 77: * The command is enabled (isExecutionAllowed == true) if it's available Line 78: * and all the selected disks quota mode != QuotaEnforcementTypeEnum.DISABLED. Line 79: * @param changeQuotaCommad Line 80: */ Line 81: public static void updateChangeQuotaActionAvailability(IChangeQuotaCommadAvailability changeQuotaCommad) { changeQuotaCommad: * s/Commad/Command * is it a command or a model? Line 82: boolean isAvailable = true, isExecutionAllowed = true; Line 83: if (changeQuotaCommad.getSystemTreeSelectedItem() != null Line 84: && changeQuotaCommad.getSystemTreeSelectedItem().getType() == SystemTreeItemType.DataCenter) { Line 85: List<Disk> selectedDisks = changeQuotaCommad.getSelectedDisks(); .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/IChangeQuotaCommadAvailability.java Line 5: import org.ovirt.engine.core.common.businessentities.Disk; Line 6: import org.ovirt.engine.ui.uicommonweb.UICommand; Line 7: import org.ovirt.engine.ui.uicommonweb.models.ISupportSystemTreeContext; Line 8: Line 9: public interface IChangeQuotaCommadAvailability extends ISupportSystemTreeContext { * s/Command/Command * Why do you need a new interface? Can't you just pass what you need to the static 'updateChangeQuotaActionAvailability' method? Line 10: public UICommand getChangeQuotaCommand(); Line 11: Line 12: public List<Disk> getDisks(); Line 13: -- To view, visit http://gerrit.ovirt.org/13925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
