Kanagaraj M has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncManager.java
Line 105: * @return
Line 106: */
Line 107: private EngineLock getEngineLock(Guid clusterId) {
Line 108: return new
EngineLock(Collections.singletonMap(clusterId.toString(),
Line 109:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER,
VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED)), null);
all the lock related method also can be moved to the super class.
Line 110: }
Line 111:
Line 112: /**
Line 113: * Refreshes details of all volume across all clusters being
managed in the engine. It can end up doing the
--
To view, visit http://gerrit.ovirt.org/13944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d851928f18da22b352b7be9d6ccaf4382e7930
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
