Shireesh Anjal has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
very minor comment in-line.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java
Line 37: protected GlusterAuditLogUtil logUtil =
GlusterAuditLogUtil.getInstance();
Line 38:
Line 39:
Line 40: public GlusterJob() {
Line 41: super();
why this call to super()? Probably this constructor itself is not required.
Line 42: }
Line 43:
Line 44: /**
Line 45: * Required so that the log util can be mocked in the JUnit test
--
To view, visit http://gerrit.ovirt.org/13944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d851928f18da22b352b7be9d6ccaf4382e7930
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
