Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java
Line 29:
Line 30: private static VmPropertiesUtils vmPropertiesUtils = null;
Line 31:
Line 32: public static VmPropertiesUtils getInstance() {
Line 33: if (vmPropertiesUtils == null) {
Why the singleton initialization change?
You can also consider perhaps using the Answer that suggests "lazy
initialization singleton".
http://stackoverflow.com/questions/878577/are-java-static-initializers-thread-safe.
And if "double check lock" - don't we need to add volatile here?
Line 34: synchronized (VmPropertiesUtils.class) {
Line 35: if (vmPropertiesUtils == null) {
Line 36: vmPropertiesUtils = new VmPropertiesUtils();
Line 37: }
--
To view, visit http://gerrit.ovirt.org/13397
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bbdb54d150878123968893c23169de253e1ba2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
