Alon Bar-Lev has posted comments on this change.
Change subject: packaging: stricter FQDN validation
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
I will stop bothering you :)
....................................................
File packaging/fedora/setup/common_utils.py
Line 625: addressmatch = addressre.match(line)
Line 626: if interfacematch is not None:
Line 627: interfaces[interfacematch.group('interface')] = \
Line 628: 'LOOPBACK' in interfacematch.group('options')
Line 629: addresses.setdefault(
If these independent parsers, the addresses should only be used at the next
clause... :)
Line 630: interfacematch.group('interface'),
Line 631: []
Line 632: )
Line 633: elif addressmatch is not None:
Line 640:
Line 641: iplist = []
Line 642: for interface, loopback in interfaces.iteritems():
Line 643: if not loopback:
Line 644: iplist.extend(addresses[interface])
Oh... now I get it...
Was the problem?
iplist.extend(addresses.get(interface, []))
Line 645: return set(iplist)
Line 646:
Line 647:
Line 648: def getCurrentDateTime(isUtc=None):
--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
