Alex Lourie has posted comments on this change. Change subject: packaging: stricter FQDN validation ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/fedora/setup/common_utils.py Line 618: cmdList=cmd, Line 619: failOnError=True, Line 620: msg=output_messages.ERR_EXP_GET_CFG_IPS_CODES Line 621: ) Line 622: lines = output.splitlines() Obsolete? Line 623: for line in output.splitlines(): Line 624: interfacematch = interfacere.match(line) Line 625: addressmatch = addressre.match(line) Line 626: if interfacematch is not None: -- To view, visit http://gerrit.ovirt.org/13933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
