Itamar Heim has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 2: (3 inline comments)
what do you mean by "integrating customized websockets script into engine
itself"?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
Line 358: return clientOsType().equalsIgnoreCase("Linux") &&
clientBrowserType().equalsIgnoreCase("Firefox"); //$NON-NLS-1$ //$NON-NLS-2$
Line 359: }
Line 360:
Line 361: public boolean isClientWindowExplorerWithWebsockets() {
Line 362: return isClientWindowsExplorer(); //TODO add check for ie 10
isn't there a more programmatic way to check for websocket support (i assume
browser can disable it as well even if supported)?
what if it is an older firefox, or something else, etc?
Line 363: }
Line 364:
Line 365: public boolean isClientWindowsExplorer() {
Line 366: return isClientWindows() &&
clientBrowserType().equalsIgnoreCase("Explorer"); //$NON-NLS-1$ //$NON-NLS-2$
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
Line 22: import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback;
Line 23:
Line 24: public class VncConsoleModel extends ConsoleModel {
Line 25:
Line 26: private static final int TICKET_VALIDITY_SECONDS = 120;
this shouldn't be hard coded (or needed at all - see next comment)
Line 27:
Line 28: private String host;
Line 29:
Line 30: private String otp64 = null;
Line 75:
Line 76: private void setVmTicket() {
Line 77: Frontend.RunAction(VdcActionType.SetVmTicket, new
SetVmTicketParameters(getEntity().getId(),
Line 78: null,
Line 79: TICKET_VALIDITY_SECONDS), new
IFrontendActionAsyncCallback() {
why do you need to set the timeout? I'd expect engine to accept an empty call
and generate the ticket on the engine default ticket timeout?
Line 80:
Line 81: @Override
Line 82: public void Executed(FrontendActionAsyncResult result)
{
Line 83:
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
